diff --git a/bukkit/src/main/java/net/william278/husksync/BukkitHuskSync.java b/bukkit/src/main/java/net/william278/husksync/BukkitHuskSync.java index 76319f14..922454d1 100644 --- a/bukkit/src/main/java/net/william278/husksync/BukkitHuskSync.java +++ b/bukkit/src/main/java/net/william278/husksync/BukkitHuskSync.java @@ -60,7 +60,6 @@ import net.william278.husksync.util.BukkitMapPersister; import net.william278.husksync.util.BukkitTask; import net.william278.husksync.util.LegacyConverter; import org.bstats.bukkit.Metrics; -import org.bukkit.Bukkit; import org.bukkit.entity.Player; import org.bukkit.map.MapView; import org.bukkit.plugin.java.JavaPlugin; @@ -229,7 +228,7 @@ public class BukkitHuskSync extends JavaPlugin implements HuskSync, BukkitTask.S @Override @NotNull public Set getOnlineUsers() { - return Bukkit.getOnlinePlayers().stream() + return getServer().getOnlinePlayers().stream() .map(player -> BukkitUser.adapt(player, this)) .collect(Collectors.toSet()); } @@ -237,7 +236,7 @@ public class BukkitHuskSync extends JavaPlugin implements HuskSync, BukkitTask.S @Override @NotNull public Optional getOnlineUser(@NotNull UUID uuid) { - final Player player = Bukkit.getPlayer(uuid); + final Player player = getServer().getPlayer(uuid); if (player == null) { return Optional.empty(); } @@ -253,12 +252,10 @@ public class BukkitHuskSync extends JavaPlugin implements HuskSync, BukkitTask.S @NotNull @Override public Map getPlayerCustomDataStore(@NotNull OnlineUser user) { - if (playerCustomDataStore.containsKey(user.getUuid())) { - return playerCustomDataStore.get(user.getUuid()); - } - final Map data = Maps.newHashMap(); - playerCustomDataStore.put(user.getUuid(), data); - return data; + return playerCustomDataStore.compute( + user.getUuid(), + (uuid, data) -> data == null ? Maps.newHashMap() : data + ); } @Override @@ -269,7 +266,7 @@ public class BukkitHuskSync extends JavaPlugin implements HuskSync, BukkitTask.S @Override public boolean isDependencyLoaded(@NotNull String name) { - return Bukkit.getPluginManager().getPlugin(name) != null; + return getServer().getPluginManager().getPlugin(name) != null; } // Register bStats metrics @@ -303,7 +300,7 @@ public class BukkitHuskSync extends JavaPlugin implements HuskSync, BukkitTask.S @NotNull @Override public Version getMinecraftVersion() { - return Version.fromString(Bukkit.getBukkitVersion()); + return Version.fromString(getServer().getBukkitVersion()); } @NotNull @@ -347,7 +344,7 @@ public class BukkitHuskSync extends JavaPlugin implements HuskSync, BukkitTask.S @Override @NotNull - public HuskSync getPlugin() { + public BukkitHuskSync getPlugin() { return this; } diff --git a/bukkit/src/main/java/net/william278/husksync/data/BukkitUserDataHolder.java b/bukkit/src/main/java/net/william278/husksync/data/BukkitUserDataHolder.java index 05ac07d9..1d85a1be 100644 --- a/bukkit/src/main/java/net/william278/husksync/data/BukkitUserDataHolder.java +++ b/bukkit/src/main/java/net/william278/husksync/data/BukkitUserDataHolder.java @@ -25,7 +25,6 @@ import org.bukkit.entity.Player; import org.bukkit.inventory.PlayerInventory; import org.jetbrains.annotations.NotNull; -import java.util.Map; import java.util.Optional; public interface BukkitUserDataHolder extends UserDataHolder { @@ -140,9 +139,6 @@ public interface BukkitUserDataHolder extends UserDataHolder { @NotNull Player getBukkitPlayer(); - @NotNull - Map getCustomDataStore(); - @NotNull default BukkitMapPersister getMapPersister() { return (BukkitHuskSync) getPlugin(); diff --git a/bukkit/src/main/java/net/william278/husksync/util/BukkitMapPersister.java b/bukkit/src/main/java/net/william278/husksync/util/BukkitMapPersister.java index 9b640ba1..bf92a39c 100644 --- a/bukkit/src/main/java/net/william278/husksync/util/BukkitMapPersister.java +++ b/bukkit/src/main/java/net/william278/husksync/util/BukkitMapPersister.java @@ -25,7 +25,7 @@ import de.tr7zw.changeme.nbtapi.iface.ReadWriteNBT; import de.tr7zw.changeme.nbtapi.iface.ReadableNBT; import net.querz.nbt.io.NBTUtil; import net.querz.nbt.tag.CompoundTag; -import net.william278.husksync.HuskSync; +import net.william278.husksync.BukkitHuskSync; import net.william278.mapdataapi.MapBanner; import net.william278.mapdataapi.MapData; import org.bukkit.Bukkit; @@ -85,7 +85,7 @@ public interface BukkitMapPersister { // Perform an operation on each map in an array of ItemStacks @NotNull - private ItemStack[] forEachMap(@NotNull ItemStack[] items, @NotNull Function function) { + private ItemStack[] forEachMap(ItemStack[] items, @NotNull Function function) { for (int i = 0; i < items.length; i++) { final ItemStack item = items[i]; if (item == null) { @@ -148,7 +148,7 @@ public interface BukkitMapPersister { // Search for an existing map view Optional world = Optional.empty(); for (String worldUid : mapIds.getKeys()) { - world = Bukkit.getWorlds().stream() + world = getPlugin().getServer().getWorlds().stream() .map(w -> w.getUID().toString()).filter(u -> u.equals(worldUid)) .findFirst(); if (world.isPresent()) { @@ -441,6 +441,6 @@ public interface BukkitMapPersister { @ApiStatus.Internal @NotNull - HuskSync getPlugin(); + BukkitHuskSync getPlugin(); }