Remove async execution `nativeSyncPlayerAdvancements`;

feat/data-edit-commands
Harvels X 3 years ago
parent 5bbb4a8547
commit efc2c0199b
No known key found for this signature in database
GPG Key ID: 9637BCFE856BB8F3

@ -20,8 +20,6 @@ import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType; import org.bukkit.potion.PotionEffectType;
import java.io.IOException; import java.io.IOException;
import java.time.Instant;
import java.time.Period;
import java.util.*; import java.util.*;
import java.util.logging.Level; import java.util.logging.Level;
@ -164,7 +162,6 @@ public class PlayerSetter {
= DataSerializer.deserializeAdvancementData(data.getSerializedAdvancements()); = DataSerializer.deserializeAdvancementData(data.getSerializedAdvancements());
if (Settings.useNativeImplementation) { if (Settings.useNativeImplementation) {
Bukkit.getScheduler().runTaskAsynchronously(plugin, () -> {
try { try {
nativeSyncPlayerAdvancements(player, advancementRecords); nativeSyncPlayerAdvancements(player, advancementRecords);
} catch (Exception e) { } catch (Exception e) {
@ -177,7 +174,6 @@ public class PlayerSetter {
setPlayerAdvancements(player, advancementRecords, data); setPlayerAdvancements(player, advancementRecords, data);
plugin.getLogger().log(Level.SEVERE, e.getMessage(), e); plugin.getLogger().log(Level.SEVERE, e.getMessage(), e);
} }
});
} else { } else {
setPlayerAdvancements(player, advancementRecords, data); setPlayerAdvancements(player, advancementRecords, data);
} }
@ -310,12 +306,9 @@ public class PlayerSetter {
AdvancementUtils.startProgress(playerAdvancements, advancement, nativeAdvancementProgress); AdvancementUtils.startProgress(playerAdvancements, advancement, nativeAdvancementProgress);
} }
}); });
synchronized (playerAdvancements) {
AdvancementUtils.ensureAllVisible(playerAdvancements); // Set all completed advancement is visible AdvancementUtils.ensureAllVisible(playerAdvancements); // Set all completed advancement is visible
AdvancementUtils.markPlayerAdvancementsFirst(playerAdvancements); // Mark the sending of visible advancement as the first AdvancementUtils.markPlayerAdvancementsFirst(playerAdvancements); // Mark the sending of visible advancement as the first
} }
}
/** /**
* Update a player's advancements and progress to match the advancementData * Update a player's advancements and progress to match the advancementData

Loading…
Cancel
Save